Layout by Lyusena and Julie #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avplatonov
reviewed
Mar 25, 2019
Owner
avplatonov
left a comment
avplatonov
left a comment
There was a problem hiding this comment.
@Lyusena , thank you for your contribution
Please, review my comments. I think you should be more careful in namings.
| @@ -0,0 +1,331 @@ | |||
| body { | |||
Owner
There was a problem hiding this comment.
In my opinion, you should name *.css files more precisely because "css" is already about "style". If this css-file are built for all pages you can name it like "base.css" or something like this.
Author
There was a problem hiding this comment.
@avplatonov, i agree with the observation. Edits made.
frontend_layout/css/stylelog.css
Outdated
| @@ -0,0 +1,283 @@ | |||
| body { | |||
Owner
There was a problem hiding this comment.
same as above (style.css)
"stylename" is inexplicable name. I cannot understand what kind of content are present there without reading html and css together.
Author
There was a problem hiding this comment.
Sorry, it was an experiment I forgot to delete from the catalog.
frontend_layout/css/stylelog.css
Outdated
| height: 45px; | ||
| } | ||
|
|
||
| .wrap2 |
Owner
There was a problem hiding this comment.
I thing you should care about naming.
There are a lot of names having obscure mean.
Author
There was a problem hiding this comment.
Julia and I will work on it, but I can't fix it now.
frontend_layout/css/stylelog.css
Outdated
|
|
||
| .wrap | ||
| { | ||
| width: 100%; /* ������� ������������ ���� �������� */ |
Owner
There was a problem hiding this comment.
please use comments in English
| @@ -0,0 +1 @@ | |||
| [{"uuidShedule":"10dff115d-61a1-43e4-8ab1-822d6db73260","graphName":"Graph 2", "state":"Started", "author":"молодцы","start":"-", "end":"-","tags":"ML"},{"uuidShedule":"9dff115d-61a1-43e4-8zb1-822d6db73260","graphName":"Graph 1", "state":"Planing", "author":"Alex","start":"-", "end":"-","tags":"NLP ML"},{"uuidShedule":"9dff115d-61a1-43e4-8ab1-822d6db73260","graphName":"Graph0","state":"planning","author":"0","start":"2018-11-17T11:25:03.189+0000","end":"2067-10-03T22:50:06.378+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"5f9fca0f-a632-4741-8652-cf0af817794f","graphName":"Graph1","state":"planning","author":"1","start":"2018-11-17T11:25:03.189+0000","end":"2043-04-26T17:07:34.783+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"b283ab7c-e39f-455f-9584-b69a2f775e80","graphName":"Graph2","state":"started","author":"2","start":"2018-11-17T11:25:03.189+0000","end":"2035-03-04T07:13:24.252+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"d80bc49b-0369-4b16-a40f-4e32bfa3574f","graphName":"Graph3","state":"started","author":"3","start":"2018-11-17T11:25:03.189+0000","end":"2031-02-05T14:16:18.986+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"1fae0fab-b94a-43c5-82da-f43b6d01ee60","graphName":"Graph4","state":"failed","author":"4","start":"2018-11-17T11:25:03.189+0000","end":"2028-08-26T23:18:03.826+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"b8d84b5d-e442-4123-b81c-07a39e8a7b0a","graphName":"Graph5","state":"failed","author":"5","start":"2018-11-17T11:25:03.190+0000","end":"2027-01-09T21:19:13.721+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"2e4c3b3c-ab20-41cf-b67f-d249041f318f","graphName":"Graph6","state":"succeed","author":"6","start":"2018-11-17T11:25:03.190+0000","end":"2025-11-10T19:54:20.788+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"c278e63a-32e0-4e8b-bf6c-64f6bebb4f31","graphName":"Graph7","state":"succeed","author":"7","start":"2018-11-17T11:25:03.190+0000","end":"2024-12-27T00:50:41.088+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"bd3c2098-1e37-4137-a9be-b3e270a06b6b","graphName":"Graph8","state":"canceled","author":"8","start":"2018-11-17T11:25:03.190+0000","end":"2024-04-23T02:01:10.211+0000","tags":["0","1","2","3","4","5","6","7","8","9"]},{"uuidShedule":"fbb7385a-c450-4f01-898b-add8ac78e499","graphName":"Graph9","state":"canceled","author":"9","start":"2018-11-17T11:25:03.190+0000","end":"2023-10-07T17:21:33.509+0000","tags":["0","1","2","3","4","5","6","7","8","9"]}] No newline at end of file | |||
Owner
There was a problem hiding this comment.
this is a test data
I think that this file should be placed into specific directory like "data/test/..."
| @@ -0,0 +1,2 @@ | |||
| //code.iamkate.com | |||
| var CollapsibleLists=function(){function e(b,c){[].forEach.call(b.getElementsByTagName("li"),function(a){c&&b!==a.parentNode||(a.style.userSelect="none",a.style.MozUserSelect="none",a.style.msUserSelect="none",a.style.WebkitUserSelect="none",a.addEventListener("click",g.bind(null,a)),f(a))})}function g(b,c){for(var a=c.target;"LI"!==a.nodeName;)a=a.parentNode;a===b&&f(b)}function f(b){var c=b.classList.contains("collapsibleListClosed"),a=b.getElementsByTagName("ul");[].forEach.call(a,function(a){for(var d=a;"LI"!==d.nodeName;)d=d.parentNode;d===b&&(a.style.display=c?"block":"none")});b.classList.remove("collapsibleListOpen");b.classList.remove("collapsibleListClosed");0<a.length&&b.classList.add("collapsibleList"+(c?"Open":"Closed"))}return{apply:function(b){[].forEach.call(document.getElementsByTagName("ul"),function(c){c.classList.contains("collapsibleList")&&(e(c,!0),b||[].forEach.call(c.getElementsByTagName("ul"),function(a){a.classList.add("collapsibleList")}))})},applyTo:e}}(); No newline at end of file | |||
Owner
There was a problem hiding this comment.
please, use lowercase and "_" in file names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few pages on the web